Fix Vec * Mat (#175)

* Fix Vec * Mat

* Update muladd.jl

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "1.4"
+version = "1.4.1"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/muladd.jl

@@ -189,6 +189,23 @@ function default_blasmul!(α, A::AbstractMatrix, B::AbstractMatrix, β, C::Abstr
     C
 end
 
+function default_blasmul!(α, A::AbstractVector, B::AbstractMatrix, β, C::AbstractMatrix)
+    mA, = size(A)
+    mB, nB = size(B)
+    1 == mB || throw(DimensionMismatch("Dimensions must match"))
+    size(C) == (mA, nB) || throw(DimensionMismatch("Dimensions must match"))
+
+    lmul!(β, C)
+
+    (iszero(mA) || iszero(nB)) && return C
+
+    for k in colsupport(A), j in rowsupport(B)
+        _default_blasmul_loop!(α, A, B, β, C, k, j)
+    end
+    C
+end
+
+
 function _default_blasmul!(::IndexLinear, α, A::AbstractMatrix, B::AbstractVector, β, C::AbstractVector)
     mA, nA = size(A)
     mB = length(B)
@@ -266,6 +283,11 @@ function materialize!(M::MatMulVecAdd)
     default_blasmul!(α, unalias(C,A), unalias(C,B), iszero(β) ? false : β, C)
 end
 
+function materialize!(M::VecMulMatAdd)
+    α, A, B, β, C = M.α, M.A, M.B, M.β, M.C
+    default_blasmul!(α, unalias(C,A), unalias(C,B), iszero(β) ? false : β, C)
+end
+
 @inline _gemv!(tA, α, A, x, β, y) = BLAS.gemv!(tA, α, unalias(y,A), unalias(y,x), β, y)
 @inline _gemm!(tA, tB, α, A, B, β, C) = BLAS.gemm!(tA, tB, α, unalias(C,A), unalias(C,B), β, C)
 
@@ -424,8 +446,7 @@ function similar(M::MulAdd{<:DualLayout,<:Any,ZerosLayout}, ::Type{T}, (x,y)) wh
     trans(similar(trans(M.A), T, y))
 end
 
-function similar(M::MulAdd{<:Any,<:DualLayout,ZerosLayout}, ::Type{T}, (x,y)) where T
-    @assert length(x) == 1
+function similar(M::MulAdd{ScalarLayout,<:DualLayout,ZerosLayout}, ::Type{T}, (x,y)) where T
     trans = transtype(M.B)
     trans(similar(trans(M.B), T, y))
 end
@@ -434,3 +455,4 @@ const ZerosLayouts = Union{ZerosLayout,DualLayout{ZerosLayout}}
 copy(M::MulAdd{<:ZerosLayouts, <:ZerosLayouts, <:ZerosLayouts}) = M.C
 copy(M::MulAdd{<:ZerosLayouts, <:Any, <:ZerosLayouts}) = M.C
 copy(M::MulAdd{<:Any, <:ZerosLayouts, <:ZerosLayouts}) = M.C
+

test/test_muladd.jl

@@ -731,4 +731,8 @@ Random.seed!(0)
         Y = randn(rng, 8, 2)
         @test mul(Y',X) ≈ Y'X
     end
+
+    @testset "Vec * Adj" begin
+        @test ArrayLayouts.mul(1:5, (1:4)') == (1:5) * (1:4)'
+    end
 end