Add Dotu (#174)

* Add Dotu

* Update mul.jl

* Update test_muladd.jl

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "1.3.1"
+version = "1.4"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/mul.jl

@@ -356,14 +356,43 @@ struct Dot{StyleA,StyleB,ATyp,BTyp}
     B::BTyp
 end
 
-@inline Dot(A::ATyp,B::BTyp) where {ATyp,BTyp} = Dot{typeof(MemoryLayout(ATyp)), typeof(MemoryLayout(BTyp)), ATyp, BTyp}(A, B)
+"""
+    Dotu(A, B)
+
+is a lazy version of `BLAS.dotu(A, B)`, designed to support
+materializing based on `MemoryLayout`.
+"""
+struct Dotu{StyleA,StyleB,ATyp,BTyp}
+    A::ATyp
+    B::BTyp
+end
+
+
+
+for Dt in (:Dot, :Dotu)
+    @eval begin
+        @inline $Dt(A::ATyp,B::BTyp) where {ATyp,BTyp} = $Dt{typeof(MemoryLayout(ATyp)), typeof(MemoryLayout(BTyp)), ATyp, BTyp}(A, B)
+        @inline materialize(d::$Dt) = copy(instantiate(d))
+        @inline eltype(D::$Dt) = promote_type(eltype(D.A), eltype(D.B))
+    end
+end
 @inline copy(d::Dot) = invoke(LinearAlgebra.dot, Tuple{AbstractArray,AbstractArray}, d.A, d.B)
-@inline materialize(d::Dot) = copy(instantiate(d))
+@inline copy(d::Dotu{<:AbstractStridedLayout,<:AbstractStridedLayout,<:AbstractVector{T},<:AbstractVector{T}}) where T <: BlasComplex = BLAS.dotu(d.A, d.B)
+@inline copy(d::Dotu{<:AbstractStridedLayout,<:AbstractStridedLayout,<:AbstractVector{T},<:AbstractVector{T}}) where T <: BlasReal = BLAS.dot(d.A, d.B)
+@inline copy(d::Dotu) = LinearAlgebra._dot_nonrecursive(d.A, d.B)
+
 @inline Dot(M::Mul{<:DualLayout,<:Any,<:AbstractMatrix,<:AbstractVector}) = Dot(M.A', M.B)
-@inline mulreduce(M::Mul{<:DualLayout,<:Any,<:AbstractMatrix,<:AbstractVector}) = Dot(M)
-@inline eltype(D::Dot) = promote_type(eltype(D.A), eltype(D.B))
+@inline Dotu(M::Mul{<:DualLayout,<:Any,<:AbstractMatrix,<:AbstractVector}) = Dotu(transpose(M.A), M.B)
+
+@inline _dot_or_dotu(::typeof(transpose), ::Type{<:Complex}, M) = Dotu(M)
+@inline _dot_or_dotu(_, _, M) = Dot(M)
+@inline mulreduce(M::Mul{<:DualLayout,<:Any,<:AbstractMatrix,<:AbstractVector}) = _dot_or_dotu(dualadjoint(M.A), eltype(M.A), M)
+
+
 
 dot(a, b) = materialize(Dot(a, b))
+dotu(a, b) = materialize(Dotu(a, b))
+
 @inline LinearAlgebra.dot(a::LayoutArray, b::LayoutArray) = dot(a,b)
 @inline LinearAlgebra.dot(a::LayoutArray, b::AbstractArray) = dot(a,b)
 @inline LinearAlgebra.dot(a::AbstractArray, b::LayoutArray) = dot(a,b)

test/test_muladd.jl

@@ -675,12 +675,28 @@ Random.seed!(0)
         @test M[1,1] ≈ M[CartesianIndex(1,1)] ≈ M[1] ≈ (b*b')[1,1]
     end
 
-    @testset "Dot" begin
+    @testset "Dot/Dotu" begin
         a = randn(5)
         b = randn(5)
-        @test ArrayLayouts.dot(a,b) == mul(a',b)
+        c = randn(5) + im*randn(5)
+        d = randn(5) + im*randn(5)
+        
+        @test ArrayLayouts.dot(a,b) == ArrayLayouts.dotu(a,b) == mul(a',b)
         @test ArrayLayouts.dot(a,b) ≈ dot(a,b)
         @test eltype(Dot(a,1:5)) == Float64
+
+        @test ArrayLayouts.dot(c,d) == mul(c',d)
+        @test ArrayLayouts.dotu(c,d) == mul(transpose(c),d)
+        @test ArrayLayouts.dot(c,d) ≈ dot(c,d)
+        @test ArrayLayouts.dotu(c,d) ≈ BLAS.dotu(c,d)
+
+        @test ArrayLayouts.dot(c,b) == mul(c',b)
+        @test ArrayLayouts.dotu(c,b) == mul(transpose(c),b)
+        @test ArrayLayouts.dot(c,b) ≈ dot(c,b)
+        
+        @test ArrayLayouts.dot(a,d) == mul(a',d)
+        @test ArrayLayouts.dotu(a,d) == mul(transpose(a),d)
+        @test ArrayLayouts.dot(a,d) ≈ dot(a,d)
     end
 
     @testset "adjtrans muladd" begin