Diagonal(::LayoutVector) \ UpperTriangular (#176)

* Diagonal(::LayoutVector) \ UpperTriangular

* add tests

* Update test_muladd.jl

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "1.4.1"
+version = "1.4.2"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/ArrayLayouts.jl

@@ -248,8 +248,6 @@ end
 \(A::Diagonal{<:Any,<:LayoutVector}, B::Diagonal{<:Any,<:LayoutVector}) = ldiv(A, B)
 \(A::Diagonal{<:Any,<:LayoutVector}, B::AbstractMatrix) = ldiv(A, B)
 \(A::AbstractMatrix, B::Diagonal{<:Any,<:LayoutVector}) = ldiv(A, B)
-\(A::Diagonal{<:Any,<:LayoutVector}, B::LayoutMatrix) = ldiv(A, B)
-\(A::LayoutMatrix, B::Diagonal{<:Any,<:LayoutVector}) = ldiv(A, B)
 \(A::Diagonal{<:Any,<:LayoutVector}, B::Diagonal) = ldiv(A, B)
 \(A::Diagonal, B::Diagonal{<:Any,<:LayoutVector}) = ldiv(A, B)
 

src/ldiv.jl

@@ -197,6 +197,8 @@ macro _layoutldiv(Typ)
         ret = quote
             $ret
             (\)(A::$Typ, x::LayoutVector; kwds...) = ArrayLayouts.ldiv(A,x; kwds...)
+            (\)(x::Diagonal{<:Any,<:LayoutVector}, A::$Typ; kwds...) = ArrayLayouts.ldiv(x,A; kwds...)
+            \(A::$Typ, B::Diagonal{<:Any,<:LayoutVector}; kwds...) = ArrayLayouts.ldiv(A, B; kwds...)
         end
     end
     if Typ ≠ :LayoutMatrix

test/test_layoutarray.jl

@@ -245,6 +245,9 @@ MemoryLayout(::Type{MyVector}) = DenseColumnMajor()
                 @test transpose(x) / A isa Transpose
                 @test x' / A isa Adjoint
             end
+
+            @test D \ UpperTriangular(A) ≈ D \ UpperTriangular(A.A)
+            @test UpperTriangular(A) \ D ≈ UpperTriangular(A.A) \ D
         end
 
         @testset "dot" begin

test/test_muladd.jl

@@ -615,7 +615,7 @@ Random.seed!(0)
         Q = qr(randn(5,5)).Q
         b = randn(5)
         B = randn(5,5)
-        @test Q*1.0 == ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 5, 5))
+        @test Q*1.0 ≈ ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 5, 5))
         @test Q*b == ArrayLayouts.lmul!(Q, copy(b)) == mul(Q,b)
         @test Q*B == ArrayLayouts.lmul!(Q, copy(B)) == mul(Q,B)
         @test B*Q == ArrayLayouts.rmul!(copy(B), Q) == mul(B,Q)
@@ -634,7 +634,7 @@ Random.seed!(0)
         Q = qr(randn(7,5)).Q
         b = randn(5)
         B = randn(5,5)
-        @test Q*1.0 == ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 7, 7))
+        @test Q*1.0 ≈ ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 7, 7))
         @test Q*b == mul(Q,b)
         @test Q*B == mul(Q,B)
         @test 1.0*Q ≈ ArrayLayouts.rmul!(Matrix{Float64}(I, 7, 7), Q)
@@ -681,7 +681,7 @@ Random.seed!(0)
         c = randn(5) + im*randn(5)
         d = randn(5) + im*randn(5)
 
-        @test ArrayLayouts.dot(a,b) == ArrayLayouts.dotu(a,b) == mul(a',b)
+        @test ArrayLayouts.dot(a,b) ≈ ArrayLayouts.dotu(a,b) ≈ mul(a',b)
         @test ArrayLayouts.dot(a,b) ≈ dot(a,b)
         @test eltype(Dot(a,1:5)) == Float64