cli: rebuild loader_lib.c when the layout of jl_options changes - #63064
Merged
Conversation
vchuravy
approved these changes
Sep 8, 2026
Member
|
Hi @levy, thank you for your PR and contribution. Please read https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#contributor-checklist in particular
Some of your other PRs feel like they should have a generative AI disclosure. We also have some rules for AI attribution in https://github.com/JuliaLang/julia/blob/master/AGENTS.md#for-all-changes |
Contributor
Author
|
Ah, I'm sorry, I was not aware of that. I took care of reviewing to my best knowledge. |
`loader_lib.c` defines `jl_options` for the public library, and its rule did not depend on `jloptions.h`. A field added to `jl_options_t` therefore left the library reserving the old size while the runtime read the new one, which is a read past the end of the object and a value out of nowhere. Assisted-by: Claude Code (Opus 5)
levy
force-pushed
the
pr-cli-loader-options-dep
branch
from
September 8, 2026 08:48
5f32073 to
8b5e61d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/loader_lib.cdefinesjl_optionsfor the public library, but its rule did not depend onsrc/jloptions.h. After a field is added tojl_options_t, an incremental build leaves the library with the old size whilelibjulia-internalreads the new layout: a read past the end of the object. Found while adding an option in #63069. The header goes into the rule's dependencies.Disclosure: developed with Claude Code (Opus 5) under my direction. It wrote the code and this text; the measurements were run on my machine. I reviewed the changes. The commits carry an
Assisted-bytrailer.