Tweak USDT provider to allow WITH_DTRACE=1 build on macOS
#60532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you add a comment to these struct definitions? And perhaps add your adjusted drace script to contrib? I am not at my laptop right now, but I think there is also a documentation section about using bpftrace. |
Our USDT provider and `JL_PROBE_*` infrastructure, which appears to be written
for bpftrace, is also usable with macOS dtrace as long as we work around a
[known dtrace
bug](https://www.davepacheco.net/blog/2009/anatomy-of-a-dtrace-usdt-provider/#rough-edges)
that many others have worked around in the [same silly
way](https://github.com/search?q=language%3ADTrace+%22dummy%22&type=code).
We can't reuse the actual probe definitions in `contrib/bpftrace`, but those can
be tweaked to work, e.g.
https://gist.github.com/mlechu/8b4fd0125ca1b0b87be802f4ba03a5b4 (run with
`dtrace -s ./rt_gc.d -p $(pgrep -n julia)`)
Member
|
And the docs I was thinking about are here https://docs.julialang.org/en/v1/devdocs/probes/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our USDT provider and
JL_PROBE_*infrastructure, which appears to be written for bpftrace, is also usable with macOS dtrace as long as we work around a known dtrace bug that many others have worked around in the same silly way.We can't reuse the actual probe definitions in
contrib/bpftrace, but those can be tweaked to work, e.g. https://gist.github.com/mlechu/8b4fd0125ca1b0b87be802f4ba03a5b4 (run withsudo dtrace -s ./rt_gc.d -p $(pgrep -n julia); no need to disable SIP for these)