test/trimming/Project.toml: Remove stale JLLWrappers dep
#59739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Actually, @topolarity why is JLLWrappers included as a direct dep in the |
Member
|
Probably either an accident or at one time it needed a special branch but no longer does |
DilumAluthge
changed the title
test/trimming/Project.toml: Add compat entry for JLLWrapperstest/trimming/Project.toml: Remove stale JLLWrappers dep
topolarity
approved these changes
Oct 3, 2025
Member
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Oh, I remember now - This dependency must have been dropped when Zstd_jll was made a stdlib.
It would be best to change this test to also cover some "true" JLL via JLLWrappers, but that will need an updated test so for now this seems OK to me.
Member
Author
|
Can we also remove |
Member
|
No, we can't do that until LazyLibrary is supported by |
DilumAluthge
added
test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libdl,Sockets, andTestare non-upgradeable stdlibs that live in the JuliaLang/julia source tree, so I didn't include compat entries for them.Zstd_jllis vendored undertest/trimming/Zstd_jll, and is included via[sources], so I don't think we need a compat entry for that either.A compat entry for
JSONwas added in #59738.So that just leaves
JLLWrappers.