remove Irrational from hash(::Real) fallback #58375
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically, this will (marginally) improve the mixing / randomness of
hash(::Irrational)at the (marginal) cost of performance, since instead of3*objectid(x) -hit becomes the standardhash(x::Any) = hash_finalizer(3h - objectid(x)), but I think in practice this is more or less NFC.it just fixes the fact that
hash(::Real)was not in fact generic over all<:Realinputs as evidenced by the fact thathash(::Irrational)was manually skipping that dispatch and re-implementing the fallback sinceBase.decomposehas noIrrationalmethod. this PR would tighten the signature and lethash(::Irrational)hit the real fallback.