Allow constant propagation of mutables with const fields #58371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
May 9, 2025
Comment on lines
+232
to
+233
| return isa(val, Symbol) || isa(val, Type) || isa(val, Method) || isa(val, CodeInstance) || | ||
| !ismutable(val) || (typeof(val).name.constfields != C_NULL) |
There was a problem hiding this comment.
What about mutable singletons? Something like:
mutable struct Singleton end
There was a problem hiding this comment.
IIRC those get folded via the type system already. I couldn't make a case where it didnt do it (I only saw this case here with scoped values)
Keno
approved these changes
May 19, 2025
gbaraldi
changed the title
|
Thanks @gbaraldi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the ScopedValue code slightly better by folding away the has_default and default lookups
Still needs a test