-
-
Notifications
You must be signed in to change notification settings - Fork 15
Allow passing flags to cc compiler for linking #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This would also simplify my building configuration, because I would be able to pass |
E: #74 |
src/JuliaC.jl
Outdated
| image_recipe::ImageRecipe = ImageRecipe() | ||
| outname::String = "" | ||
| rpath::Union{String, Nothing} = nothing | ||
| cc_flags::Vector{String} = String[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are technically link flags so I would name something like ld_flags. Specially since the image recipe already has flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I know cc_flags isn't super well tested but could you add a test to this? |
d3c5ddd to
8ce9e07
Compare
|
Wasn't really sure what to test for, you could also just check the output from |
To modify the flags passed to the julia and cc compiler invocations by JuliaC, I'm using it programmatically. To modify the arguments passed to julia I can use
julia_args. If I use the JuliaC binary (juliac) I can pass arguments passed to julia using the--separator. To modify the compile command (both the compiler used and the flags passed to it) I'm usingJULIA_CC.I'd like to be able to decouple specifying the cc compiler from specifying user-supplied flags passed to the compiler, so that I can pass any flags I want while also taking advantage of the auto compiler discovery logic in
get_compiler_cmd