Merge #93

93: For some stdlibs, it is expected that the stdlib version number won't match the Julia version number r=DilumAluthge a=DilumAluthge Co-authored-by: Dilum Aluthge <[email protected]>
JuliaLang · Aug 28, 2023 · cf5aba8 · cf5aba8 · DilumAluthge · Aug 28, 2023
2 parents 00f3bd9 + 4bd5dec
commit cf5aba8
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl
@@ -143,6 +143,22 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State)
                         julia_version = Base.VersionNumber(read("VERSION", String))
                         version_match = stdlib_version isa VersionNumber && Base.thispatch(julia_version) === Base.thispatch(stdlib_version)
                         url_for_diff = chopsuffix(git_url_markdown, ".git")
+                        # Some external stdlibs intentionally have
+                        # version numbers that don't match the
+                        # Julia version number:
+                        known_rogue_versioners = [
+                            "DelimitedFiles",
+                            "Downloads",
+                        ]
+                        if version_match
+                            version_match_statement = ""
+                        else
+                            if stdlib.name in known_rogue_versioners
+                                version_match_statement = "(It's okay that it doesn't match)"
+                            else
+                                version_match_statement = "(Does not match)"
+                            end
+                        end
                         pr_body_lines = String[
                             "Stdlib: $(stdlib.name)",
                             "URL: $(git_url_markdown)",
@@ -151,7 +167,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State)
                             "Old commit: $(stdlib_current_commit_in_upstream_short)",
                             "New commit: $(stdlib_latest_commit_short)",
                             "Julia version: $(julia_version)",
-                            "$(stdlib.name) version: $(stdlib_version)$(version_match ? "" : " (Does not match)")",
+                            "$(stdlib.name) version: $(stdlib_version)$(version_match_statement)",
                             "Bump invoked by: $(bumpstdlibs_sender_ping)",
                             "Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)",
                             "",