Add @check_allocs_call
#46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Nov 20, 2023
| passed to `func` in the function call expression that `@check_allocs_call` is applied to. | ||
| For example, `@check_allocs_call 1 + 2.0` is equivalent to `check_allocs(+, (Int, Float64))`. | ||
| """ | ||
| macro check_allocs_call(ex...) |
There was a problem hiding this comment.
I think this can be a method/variant of @check_allocs. There is precedent for that with e.g. @timeit from TimerOutputs.jl: when applied to a function definition expression it enables timings for all calls, when applied to a call expression it times just that call.
There was a problem hiding this comment.
good idea, I wasn't aware this was being done elsewhere but seems relatively straightforward to explain, with no specific edge cases I could think of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation for #45
Not sure about keyword arguments, but they aren't mentioned in
check_allocseither. And I haven't added any tests, yet.