Add compat with DataStructures 0.19#30
Conversation
JamesWrigley
force-pushed
the
compat
branch
3 times, most recently
from
0ce8ed7 to
4f5122a
Compare
|
I (cough Claude cough) tried to implement a fix for the Canny test in 20004fa but I'm not fully confident that it's correct 😬 The Julia 1 tests are also failing because of some compat issue, maybe because the latest ReferenceTests only supports Julia v1.6? Other than that I think this is ready for review. |
|
Thank you for taking the time to contribute and help with that. I think the failure on Julia 1.0 is because you changed ImageCore = "0.9" to ImageCore = "0.10" in Project.toml. ImageCore = "0.9, 0.10"instead, it will pass. Do you mind making the change and updating the pull-request to see if it solves it? |
|
Hmm still fails 🤔 I'm not very good at reading the resolution failures, but maybe it's something to do with ColorTypes? |
|
What do you think about requiring Julia 1.10? |
Implemented by Claude, humanly verified.
The latest ImageCore version includes fixes for threadsafety issues that make `detect_edges()` fail with interactive threads.
|
Is there another requirement that would require Julia 1.10? |
|
Certainly compatibility with Julia 1.0.5 is an issue I see. |
|
No particular requirement, I'm just lazy 😛 And the LTS feels like a good version to bump to. |
|
Version 1.10 seems fine to me. My only concern was that it may raise the dependence version of Images.jl (which is currently set to Julia 1.6). However, that is not the case since this package is not imported in Images.jl. |
3 participants
I also took the liberty of bumping the version number.