Skip to content

WIP: implement varmult_finite#26

Draft
johnnychen94 wants to merge 1 commit into
masterfrom
jc/varmult_finite
Draft

WIP: implement varmult_finite#26
johnnychen94 wants to merge 1 commit into
masterfrom
jc/varmult_finite

Conversation

@johnnychen94
Copy link
Copy Markdown
Member

The implementation is more delicate than I thought it is; it is not very clean and there might be a lot of type-related issues in the current implementation.

I choose to keep the varfinite symbol as it's more convenient to use, if you think we should deprecate it then I can remove it.

Todo:

  • check the type stability
  • tests are needed

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2021

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.60%. Comparing base (5687005) to head (c59bc9b).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/statistics.jl 93.33% 2 Missing ⚠️
src/utils.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   92.07%   91.60%   -0.48%     
==========================================
  Files           5        5              
  Lines         227      250      +23     
==========================================
+ Hits          209      229      +20     
- Misses         18       21       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnnychen94 johnnychen94 marked this pull request as draft October 19, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant