Skip to content

avoid the remaining Core.Box in the package using https://github.com/JuliaLang/julia/pull/60478 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Dec 29, 2025
Merged

avoid the remaining Core.Box in the package using https://github.com/JuliaLang/julia/pull/60478 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions src/Tar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,23 +246,19 @@ function extract(
predicate === true_predicate || skeleton === nothing ||
error("extract: predicate and skeleton cannot be used together")
skeleton = something(skeleton, devnull)
dir isa AbstractString && (dir = String(dir))
dir_str = dir isa AbstractString ? String(dir) : dir
check_extract_tarball(tarball)
check_extract_dir(dir)
check_extract_dir(dir_str)
arg_read(tarball) do tar
arg_mkdir(dir) do dir
if copy_symlinks === nothing
copy_symlinks = !can_symlink(dir)
end
let copy_symlinks=copy_symlinks
arg_write(skeleton) do skeleton
extract_tarball(
predicate, tar, dir,
skeleton = skeleton,
copy_symlinks = copy_symlinks,
set_permissions = set_permissions,
)
end
arg_mkdir(dir_str) do dir
copy_symlinks_local = copy_symlinks === nothing ? !can_symlink(dir) : copy_symlinks
arg_write(skeleton) do skeleton
extract_tarball(
predicate, tar, dir,
skeleton = skeleton,
copy_symlinks = copy_symlinks_local,
set_permissions = set_permissions,
)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions src/extract.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,9 @@ function hash_git_tree(node::GitTree, ::Type{HashType}) where HashType <: SHA.SH
by((name, child)) = child isa GitTree ? "$name/" : name
hash = git_object_hash("tree", HashType) do io
for (name, child) in sort!(collect(node.children), by=by)
mode, hash = hash_git_tree(child, HashType)
mode, child_hash = hash_git_tree(child, HashType)
print(io, mode, ' ', name, '\0')
write(io, hex2bytes(hash))
write(io, hex2bytes(child_hash))
end
end
return ("40000", hash)
Expand Down
Loading