Implement edges function for IGraph

[subbarayudu8660]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.27%. Comparing base (50dc68e) to head (590cac2).

Files with missing lines	Patch %	Lines
src/graph_api.jl	0.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master     #26      +/-   ##
=========================================
- Coverage    6.47%   5.27%   -1.20%     
=========================================
  Files           8       8              
  Lines        4342    4323      -19     
=========================================
- Hits          281     228      -53     
- Misses       4061    4095      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Krastanov]

This is pretty impressive for jumping into it without having had prior exposure to any of these tools, good job! I think there is a much more efficient way to set it up though, check out the link I shared. And we need to add tests.

[Krastanov]

Good find! This seems like a pretty expensive allocating operation. I would expect there to be a way to iterate over edges without having to create the adjlist.

I suspect this will be a better way: https://igraph.org/c/html/latest/igraph-Iterators.html#edge-iterators

[Krastanov]

and we also need correctness tests

[subbarayudu8660]

what do you mean by correctness tests?

[Krastanov]

A new feature usually comes with additions to the test suite, so that one can attest that the feature is correctly implemented. More importantly, such tests will be executed for any change in the future, ensuring that the feature is not accidentally broken.

For instance, here you are implementing an edges function. A convenient correctness test would be some self-consistency check. E.g. create a graph by specifically adding some random set of edges. Then call the edges function on that graph and verify that it returns the same set as the initial set you started with. This type of "round trip" consistency checks are a powerful way to detect issues.

[Krastanov]

the failing tests, as you guessed in your email, are unrelated to your work -- these are just tests that have not been properly set yet