Skip to content

add tests for simplifying small rings #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafaqz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add tests for simplifying small rings #352

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3575610
add tests for simplifying small rings
rafaqz Oct 20, 2025
27f01c3
Merge branch 'main' into simplify_lr
asinghvi17 Jan 16, 2026
4787bce
Merge branch 'main' into simplify_lr
asinghvi17 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/transformations/simplify.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,9 @@ end
@test all(GI.coordinates(GO.simplify($linestring; tol = 100.0)) .== lg_vals)
end
end

@testset "Simplify small LinearRing" begin
lr = GI.LinearRing([(1, 1), (2, 2), (3, 3), (4, 4), (1, 1)])
@test GI.npoint(GO.simplify(lr, tol=10)) == 3
Copy link
Member

@asinghvi17 asinghvi17 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to give 5 points...maybe you want radial instead?

@test GI.npoint(GO.simplify(lr, number=3)) == 3
Copy link
Member

@asinghvi17 asinghvi17 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify is failing here

end
Loading