-
Notifications
You must be signed in to change notification settings - Fork 14
Finish API #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish API #187
Conversation
@kahaaga what's up with the signature Are we complicating things too much here? Why would we even care to allow this. I say we should have |
@kahaaga Unfortunately I have to change |
I think we should keep the three-argument version. This is related to the answer I linked in #184. In short:
|
Follow-up to the last post: The reason I wouldn't add separate
|
Ok, no problem. As long as the public API has an easy way to specify a fixed grid in multiple dimensions, the specifics of the underlying implementation doesn't really matter. |
ok then I merge this. In a separate PR we should separate the documentation of the entropy with hte entropy estimators into a different documentation block. especially since you say they compute differential entropy. |
Closes #185, closes #184
Implements the final version of the API which is:
encode/decode
.Also re-writes
FixedRectangularBinning
to have welldefined outcome space always.