Fix inner preparation behavior for Mooncake #948
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 133 133
Lines 7981 7982 +1
=======================================
+ Hits 7837 7838 +1
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
requested changes
Jan 6, 2026
...tionInterface/ext/DifferentiationInterfaceMooncakeExt/DifferentiationInterfaceMooncakeExt.jl
Show resolved
Hide resolved
Co-authored-by: Guillaume Dalle <[email protected]>
Contributor
Author
|
It is unlikely that I will be able to spend additional time on this, so please feel free to take it over or ignore it. |
gdalle
approved these changes
Jan 9, 2026
Member
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
Thanks, this looks good! If the tests pass i'll merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See, chalk-lab/Mooncake.jl#878 (comment)
Edit: While no longer strictly necessary following PR #926 of Mooncake.jl, this remains useful as an optimisation.