Fix type instability in LinMPC and NonLinMPC (introduced in 1.1.0)
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ControllerConstraint{NT}` is no longer concrete
`ControllerConstraint{NT, GCfunc}` is
|
oh well it happens! I will work on that a little bit tomorrow. But I have a party on Saturday. so not Saturday. And not Sunday while we're at it XD 🎉 🎉 🎉 |
baggepinnen
approved these changes
Nov 29, 2024
|
It's a common pitfall. Ways to protect yourself against future such changes are
|
|
Yeah I'll implement your second option instead. I did not know that |
franckgaga
changed the title
LinMPC and NonLinMPC (introduced in 1.2.0) LinMPC and NonLinMPC (introduced in 1.1.0)
- it's dangerous with `setmodel!` (if `L_Hp` change, `noR̂u` can be incorrect - the code is simpler (no branching) - computational gains are negligible
…s (bis) the matrices `buffer.Ẽ` and `buffer.S̃` are added to store intermediary results
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 98.99% 98.99% -0.01%
==========================================
Files 24 24
Lines 3676 3675 -1
==========================================
- Hits 3639 3638 -1
Misses 37 37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControllerConstraint{NT}is no longer concreteControllerConstraint{NT, GCfunc}is