fix invocation of npm and npx #101
Conversation
![semgrep-code-juliacomputing-new[bot]](https://avatars.githubusercontent.com/u/10258468?s=60&v=4){kind=small}
| end | ||
|
|
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Avoid writing lines with trailing whitespace.
To resolve this comment:
✨ Commit Assistant Fix Suggestion
- Find and remove any spaces or tabs at the end of each line in your code. Pay special attention to lines only containing whitespace, as well as code and comment lines that could have trailing spaces.
- Ensure that blank lines contain no spaces or tabs—each should be an empty line with just a newline character.
- Save the file and check your editor settings; many editors have an option to trim trailing whitespace automatically—enable this to help prevent future issues.
Trailing whitespace can cause unnecessary diffs and may lead to problems with tools that are sensitive to whitespace.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in [Semgrep AppSec Platform](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542204) to ignore the finding created by no-whitespace-trailing.
You can view more details about [this finding](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542204) in the Semgrep AppSec Platform.
| # so the JLL does not bundle environment information into them. | ||
| # To fix this, we wrap all uses of npx and npm inside `node() do ...` | ||
| # which will automatically adjust the necessary environment variables. | ||
| node() do |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Avoid writing lines with trailing whitespace.
To resolve this comment:
💡 Follow autofix suggestion
| node() do | |
| node() do |
View step-by-step instructions
- Delete any spaces or tabs after the code on the line
node() do.
The line should end immediately after thedo, with no extra whitespace. - Save the changes so that no lines in your code end with trailing whitespace.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in [Semgrep AppSec Platform](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542205) to ignore the finding created by no-whitespace-trailing.
You can view more details about [this finding](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542205) in the Semgrep AppSec Platform.
| end | ||
|
|
||
| pattern = "*/{$(join(config.index_versions, ","))}/**/*.{html}" | ||
|
|
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Avoid writing lines with trailing whitespace.
To resolve this comment:
✨ Commit Assistant Fix Suggestion
- Remove any extra spaces or tabs at the end of each line in your code, particularly in blank lines and comments.
- Check all lines in the affected file for trailing whitespace and delete those trailing spaces, so blank lines are truly empty and other lines have no spaces or tabs after the final character.
- Save the file after removing all trailing whitespace.
Many editors support automatic removal of trailing whitespace (for example, in VSCode, you can enable "Trim Trailing Whitespace" in settings). Removing trailing whitespace helps prevent unnecessary diffs and keeps code clean.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in [Semgrep AppSec Platform](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542203) to ignore the finding created by no-whitespace-trailing.
You can view more details about [this finding](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542203) in the Semgrep AppSec Platform.
| @info "Installing pagefind into $root." | ||
| if !success(Cmd(`$(npm) install pagefind`; dir = root)) | ||
| error("Could not install pagefind.") | ||
| # npx and npm are distributed as FileProducts, |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Avoid writing lines with trailing whitespace.
To resolve this comment:
💡 Follow autofix suggestion
| # npx and npm are distributed as FileProducts, | |
| # npx and npm are distributed as FileProducts, |
View step-by-step instructions
- Remove any spaces or tab characters at the end of the line containing
# npx and npm are distributed as FileProducts,. - Make sure to check for and remove trailing whitespace on other lines in the same file as well, to prevent similar issues.
Trailing whitespace can cause unnecessary diffs and may lead to style enforcement errors in the future.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in [Semgrep AppSec Platform](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542206) to ignore the finding created by no-whitespace-trailing.
You can view more details about [this finding](https://semgrep.dev/orgs/JuliaHub, Inc/findings/186542206) in the Semgrep AppSec Platform.
No description provided.