feat: receive and use tags in image options #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image options are being extended by tag and sha.
Previously an image option would be an image key and a type.
Now optionally an
image_tagorimage_shafield can appear in the image option and they should be used in job submission if chosen.The other bigger change is that the unique constraint on options is no longer just the key, but now it's a unique constraint on key, tag and sha. This means the same key can appear multiple times with different tag/sha combinations.
This should be nonbreaking in any direction. Older client ignores the tag/sha and will just list another option with the same key. Older instances will never send tag/sha so using a newer client there is ok too.