Define custom dict_inverse(d::Base.ImmutableDict)
#44
Conversation
The default `dict_inverse` does not work for `ImmutableDict`, because
`ImmutableDict` does not implement a `ImmutableDict{K,V}(pairs...)`
constructor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 85.89% 86.90% +1.00%
==========================================
Files 1 1
Lines 78 84 +6
==========================================
+ Hits 67 73 +6
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Bijections.jl
Outdated
| function dict_inverse(d::D) where {D<:AbstractDict} | ||
| allunique(values(d)) || throw(ArgumentError("dict is not bijective")) | ||
| return inverse_dict_type(D)(reverse.(collect(d))) | ||
| return inverse_dict_type(D)(reverse.(collect(d))...) |
There was a problem hiding this comment.
The Dict([pairs]) constructor works, but is not documented. The two official constructors are Dict([pair_tuples]) and Dict(pairs...). It seems safer to add the ..., since I would expect more AbstractDict subtype to implement this, over the undocumented version.
There was a problem hiding this comment.
The problem with the ... is that it runs into a stack overflow for large number of outputs, so I would avoid in this case where the number of entries is unbounded.
This is the fallback method so it's ok to fail. If that's the case, we add the specialized method like you are doing here with ImmutableDict.
The default
dict_inversedoes not work forImmutableDict, becauseImmutableDictdoes not implement aImmutableDict{K,V}(pairs...)constructor.Closes #43