Fix failures in IAM tests #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is expecting an `AWSException` with code `"InvalidAction"` but the caught exception had code 404. It appears to be because the response body is XML but AWS didn't set the `Content-Type` header nor did it begin the response body with a clear indicator of the content type, so the body doesn't get properly parsed. To fix this, we can expand the set of things we look for to determine when to parse as XML. Previously we were only looking for `/xml` at the end of the content or `<?xml` at the beginning of the body, but the error response has neither, so here I've added a check for `<\w+ xmlns=` at the beginning of the body. This seems to be the expected format of an XML response when the `<?xml` line is absent. Documentation suggests that `<?xml` would only be absent in the case of an `ErrorResponse` but that the `Content-Type` header would be set to `text/xml`. Evidently not true in practice...
mattBrzezinski
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is expecting an
AWSExceptionwith code"InvalidAction"but the caught exception had code 404. It appears to be because the response body is XML but AWS didn't set theContent-Typeheader nor did it begin the response body with a clear indicator of the content type, so the body doesn't get properly parsed. To fix this, we can expand the set of things we look for to determine when to parse as XML. Previously we were only looking for/xmlat the end of the content or<?xmlat the beginning of the body, but the error response has neither, so here I've added a check for<\w+ xmlns=at the beginning of the body. This seems to be the expected format of an XML response when the<?xmlline is absent. Documentation suggests that<?xmlwould only be absent in the case of anErrorResponsebut that theContent-Typeheader would be set totext/xml. Evidently not true in practice...Should fix #683.