Merge pull request #11 from kalmarek/fix/julia-1.0

Fix/julia 1.0

.github/workflows/CI.yml

@@ -9,7 +9,7 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - '1.3'
+          - '1.0'
           - '1'
           - 'nightly'
         os:

Project.toml

@@ -1,22 +1,21 @@
 name = "StarAlgebras"
 uuid = "0c0c59c1-dc5f-42e9-9a8b-b5dc384a6cd1"
 authors = ["Marek Kaluba <[email protected]>"]
-version = "0.1.3"
+version = "0.1.4"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 
 [compat]
-julia = "1"
-Groups = "0.6.0"
 GroupsCore = "0.3"
+julia = "1"
 
 [extras]
-Groups = "5d8bd718-bd84-11e8-3b40-ad14f4a32557"
+Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 GroupsCore = "d5909c97-4eac-4ecc-a3dc-fdd0858a4120"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Groups", "GroupsCore", "Random", "Test"]
+test = ["Pkg", "GroupsCore", "Random", "Test"]

src/types.jl

@@ -1,7 +1,7 @@
-abstract type AbstractStarAlgebra end
+abstract type AbstractStarAlgebra{O,T} end
 
 struct StarAlgebra{O,T,M<:MultiplicativeStructure,B<:AbstractBasis{T}} <:
-       AbstractStarAlgebra
+       AbstractStarAlgebra{O,T}
     object::O
     mstructure::M
     basis::B
@@ -96,24 +96,27 @@ function Base.isone(a::AlgebraElement)
     isone(a[k]) || return false
     return isone(b[k])
 end
+let SA = @static VERSION < v"1.3.0" ? :StarAlgebra : :AbstractStarAlgebra
+    @eval begin
+        function (A::$SA{O,T})(elt::T, S = Int) where {O,T}
+            if hasbasis(A)
+                b = basis(A)
+                i = b[elt]
+                return AlgebraElement(sparsevec([i], [one(S)], length(b)), A)
+            else
+                throw("Algebra without basis: cannot coerce $elt.")
+            end
+        end
 
-function (A::AbstractStarAlgebra)(elt, T = Int)
-    if hasbasis(A)
-        b = basis(A)
-        i = b[elt]
-        return AlgebraElement(sparsevec([i], [one(T)], length(b)), A)
-    else
-        throw("Algebra without basis: cannot coerce $elt.")
+        function (A::$SA)(x::Number)
+            g = one(object(A))
+            res = A(g, typeof(x))
+            res = mul!(res, res, x)
+            return res
+        end
     end
 end
 
-function (A::AbstractStarAlgebra)(x::Number)
-    g = one(object(A))
-    res = A(g, typeof(x))
-    res = mul!(res, res, x)
-    return res
-end
-
 Base.similar(X::AlgebraElement, ::Type{T} = eltype(X)) where {T} =
     AlgebraElement(similar(coeffs(X), T), parent(X))
 

test/runtests.jl

@@ -10,5 +10,9 @@ include("test_example_words.jl")
     include("constructors.jl")
     include("arithmetic.jl")
 
-    include("sum_of_squares.jl")
+    if VERSION >= v"1.3.0"
+        using Pkg
+        Pkg.add("Groups")
+        include("sum_of_squares.jl")
+    end
 end