-
Notifications
You must be signed in to change notification settings - Fork 0
Task bug #55
base: master
Are you sure you want to change the base?
Task bug #55
Conversation
amrondonp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please answer/fix the comments I made.
Ideally, we would not want to modify directly the ingenious code the way we did it here.
We could make a plugin in which we add javascript on demand (when the plugin is active) so that we have to touch very little existing inginious code. I am open to discussion on this.
If we decided to go with this solution instead of the plugin, I feel the change is good
| <form class="form-horizontal" method="post"> | ||
| <div class="form-group"> | ||
| <div class="col-sm-9"><input type="text" class="form-control" name="new_task_id" id="new_task_id" placeholder="New task id"/></div> | ||
| <div class="col-sm-3"><button type="submit" class"form-control" value="Create new task"/>Create task</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that you missed the '=' in class"form-control"
| <div class="form-group"> | ||
| <div class="col-sm-9"><input type="text" class="form-control" id="new_task_id" placeholder="New task id"/></div> | ||
| <div class="col-sm-3"><a href="javascript:studio_create_new_task();" class="btn btn-info btn-large btn-block">Create new task</a></div> | ||
| <form class="form-horizontal" method="post"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you put action on this form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because webpy assumes that the action goes to the same page. So I went to task_list.py and modify the POST method in there
Creating a default task file "task.yaml" on the root directory of the project. In order that is used on the creation of a new task.