Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Conversation

@amicis31
Copy link
Member

Creating a default task file "task.yaml" on the root directory of the project. In order that is used on the creation of a new task.

Copy link
Member

@amrondonp amrondonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer/fix the comments I made.

Ideally, we would not want to modify directly the ingenious code the way we did it here.

We could make a plugin in which we add javascript on demand (when the plugin is active) so that we have to touch very little existing inginious code. I am open to discussion on this.

If we decided to go with this solution instead of the plugin, I feel the change is good

<form class="form-horizontal" method="post">
<div class="form-group">
<div class="col-sm-9"><input type="text" class="form-control" name="new_task_id" id="new_task_id" placeholder="New task id"/></div>
<div class="col-sm-3"><button type="submit" class"form-control" value="Create new task"/>Create task</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that you missed the '=' in class"form-control"

<div class="form-group">
<div class="col-sm-9"><input type="text" class="form-control" id="new_task_id" placeholder="New task id"/></div>
<div class="col-sm-3"><a href="javascript:studio_create_new_task();" class="btn btn-info btn-large btn-block">Create new task</a></div>
<form class="form-horizontal" method="post">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you put action on this form?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because webpy assumes that the action goes to the same page. So I went to task_list.py and modify the POST method in there

@amicis31 amicis31 closed this Mar 16, 2018
@amicis31 amicis31 reopened this Mar 16, 2018
@amicis31 amicis31 closed this Mar 16, 2018
@amicis31 amicis31 mentioned this pull request Mar 16, 2018
@amicis31 amicis31 reopened this Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants