-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reading tsconfig file and compilerOptions, prettier supressTypeErrors message #2053
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
+ Coverage 74.80% 75.40% +0.59%
==========================================
Files 177 177
Lines 7590 7543 -47
Branches 1063 1060 -3
==========================================
+ Hits 5678 5688 +10
+ Misses 1907 1849 -58
- Partials 5 6 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b9015f
to
5c72262
Compare
5c72262
to
6633b4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look like a lot of great changes but they're ... a lot 😅. It'd be a slog for me to review all of them together. Could you please split them out into discrete PRs?
If some rely on a first one then I think it'd be reasonable to just do that first one first, with maybe a branch/comparison linked to show what would come next.
@JoshuaKGoldberg I agree. They are little bit linked together. I wonder, if I start with the one that enables suppressTypeError then we can see how the other fixes actually affect things. |
PR Checklist
status: accepting prs
Overview
supersedes #1542
tsconfig
and handling the values.compilerOptions
have been changed.typestat.json
should not disablenoImplicitAny
ornoImplicitThis
if they are enabled intsconfig
.ts.parseJsonConfigFileContent
is setup. This can been seen in action for example in include test. While before we hadinclude: []
, now we have list of files.ts-expect-error
comments, do not add full path to files. If there are multiple people working in the same project, absolute path will not be same for everyone.