Skip to content

Commit

Permalink
Fixed compile issue against V8 12
Browse files Browse the repository at this point in the history
  • Loading branch information
redbullmarky committed Feb 15, 2024
1 parent 133bf61 commit 7dcff4f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion v8js_variables.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void v8js_register_accessors(std::vector<v8js_accessor_ctx*> *accessor_list, v8:
ctx->isolate = isolate;

/* Set the variable fetch callback for given symbol on named property */
php_obj->SetAccessor(V8JS_STRL(ZSTR_VAL(property_name), static_cast<int>(ZSTR_LEN(property_name))), v8js_fetch_php_variable, NULL, v8::External::New(isolate, ctx), v8::PROHIBITS_OVERWRITING, v8::ReadOnly);
php_obj->SetAccessor(V8JS_STRL(ZSTR_VAL(property_name), static_cast<int>(ZSTR_LEN(property_name))), v8js_fetch_php_variable, NULL, v8::External::New(isolate, ctx), v8::DEFAULT, v8::ReadOnly);

/* record the context so we can free it later */
accessor_list->push_back(ctx);
Expand Down

0 comments on commit 7dcff4f

Please sign in to comment.