Skip to content

Feat/add onchanged to theme storage #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 45 commits into
base: dev
Choose a base branch
from
Draft

Feat/add onchanged to theme storage #957

wants to merge 45 commits into from

Conversation

@niko-38500
Copy link

@niko-38500 niko-38500 commented Apr 21, 2025

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Allow to subscribe to the "onChanged" storage from the custom store

Changes*

add to the base store an onChanged method and change the chrome native onchanged to be consistent with the existing call to the storage

Reference

Wait for the pr #952 to merge it

HiCreatrip and others added 30 commits February 16, 2025 14:27
@HiCreatrip
Merge branch 'main' into dev
3b2e5bd
@Jonghakseo
Merge pull request Jonghakseo#872 from Jonghakseo/main-to-dev-sync
2a0c137 
main to dev sync
@PatrykKuniczak @HiCreatrip
@Jonghakseo @ahmetveburak @lafolle @sanyu1225
main-to-dev (Jonghakseo#889)
5ca95b4 
Co-authored-by: Jonghakseo <[email protected]>
Co-authored-by: JongHak Seo <[email protected]>
Co-authored-by: Ahmet Burak <[email protected]>
Co-authored-by: Karan Chaudhary <[email protected]>
Co-authored-by: jimmy.pan <[email protected]>
@PatrykKuniczak
fix: use ValueOf from @extension/shared instead of redefining (Jo…
5aaf52b 
…nghakseo#890)
@PatrykKuniczak
chore: bump year in LICENSE (Jonghakseo#892)
9b6ea04
@PatrykKuniczak
chore: rename prettier to format in all package.json (Jonghakseo#893)
1fa3965
@PatrykKuniczak
fix: add missing eslint --fix for lint-staged (Jonghakseo#894)
5e2cd31
@PatrykKuniczak @Jonghakseo
feat/configure-eslint-for-esnext (Jonghakseo#891)
1153c28 
Co-authored-by: Jonghakseo <[email protected]>
@PatrykKuniczak
docs: remove info about git configuration refactor a little `Getting …
76bee29 
…started` points and add new with IDE/Editor settings (Jonghakseo#895)
@weilueluo
Update README instructions for setting up VS Code (Jonghakseo#898)
822f879
@PatrykKuniczak
fix: remove --cache from lint scripts and --fix from "lint" and remov…
d28f8f9 
…e unnecessary and add new rules to eslint.config.ts
@PatrykKuniczak
chore: add groups to import-x/order eslint
e693954
@PatrykKuniczak
fix: attach array of paths to all tsconfig.json files to ensure resol…
a5578c8 
…ver plugin working correctly
@PatrykKuniczak
feat: use eslint.config.ts directly with new lib(official eslint appr…
2d0573e 
…oach)
@PatrykKuniczak
fix: import path in module manager package
051add9
@PatrykKuniczak
fix: move back ignores to separate object in eslint.config.ts
e9df3da
@PatrykKuniczak
clean: run pnpm lint:fix
b3fac09
@PatrykKuniczak
fix: reconfigure groups for import-x/order to fix imports with alias …
fa0c281 
…issue
@PatrykKuniczak
clean: run pnpm lint:fix
cd623ed
@Jonghakseo
Merge pull request Jonghakseo#899 from Jonghakseo/fix/linter-scripts
be62ed3 
fix/linter-scripts
@PatrykKuniczak
feat: add 2 more rules to eslint.config.ts (Jonghakseo#900)
b71d42e
@PatrykKuniczak
Feat/change target branch for prs (Jonghakseo#901)
d0b9ad8
@PatrykKuniczak
feat/create-adding-assignes-to-pr (Jonghakseo#902)
5cdc3b6
@PatrykKuniczak
fix/github-workflows (Jonghakseo#910)
3589111
@PatrykKuniczak
feat: prettify classNames in pages components (Jonghakseo#921)
302da75
@PatrykKuniczak
fix/eslint-config (Jonghakseo#919)
afbc443
@PatrykKuniczak
deps/bump-all (Jonghakseo#922)
a12f716
@PatrykKuniczak
clean/prettify-storage-and-shared (Jonghakseo#928)
88bd6ae
@PatrykKuniczak
Merge pull request Jonghakseo#929
e6f5425 
* fix: add missing consistent-type-imports rule to eslint.config.ts
@PatrykKuniczak
fix/eslint-import-order (Jonghakseo#932)
d3413d7
PatrykKuniczak and others added 15 commits April 4, 2025 11:49
@PatrykKuniczak
fix/tailwind global styles and ToggleButton styles issue (Jonghakseo#931
20aafd1 
)
@PatrykKuniczak
fix/update README for ui and add import for css for content-ui (J…
47c275a 
…onghakseo#934)
@PatrykKuniczak
fix/module-manager (Jonghakseo#897)
a2f093d
@PatrykKuniczak
fix/module-manager devtools removing proprly (Jonghakseo#940)
e3e17e5
@PatrykKuniczak
fix/linter exports issue and adjust configs (Jonghakseo#941)
ccc6956
@PatrykKuniczak
feat/add-example-loading-and-error-#850 (Jonghakseo#933)
9c9dce0
@PatrykKuniczak
feat/configure restriction for importing type-fest (Jonghakseo#944)
a80999d
@PatrykKuniczak
fix/add-eslint-import-checking (Jonghakseo#945)
e120061
@PatrykKuniczak
feat/edit-gh-workflow (Jonghakseo#946)
da728ab
@PatrykKuniczak
fix/remove closing other actions on branch change(workflow) (Jonghaks…
bb50489 
…eo#947)
@PatrykKuniczak
fix/remove already-exists section from auto-change-prs-branch (Jong…
8be8cd4 
…hakseo#948)
@PatrykKuniczak
chore/add 'on' reopened for change branch workflow (Jonghakseo#949)
1651106
feat(ui): tailwind native dark mode
ee284f0 
allow to use the native tailwind dark mode (dark:*) for a better DX
fix pr review
df40c4c
feat(storage): add onchanged listener
71c8ec6 
allow to add an on changed listener for the stores
@github-actions github-actions bot changed the base branch from main to dev April 21, 2025 20:47
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

Your PR's base branch was set to main, PRs should be set to target dev.
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@PatrykKuniczak
Copy link
Collaborator

PatrykKuniczak commented May 7, 2025

@niko-38500 Are you'll go forward with your PRs?

@niko-38500
Copy link
Author

niko-38500 commented May 8, 2025

Yes but I'm in holiday right now, I'll resume it when I'm back

@Jonghakseo Jonghakseo deleted the branch Jonghakseo:dev May 25, 2025 13:35
@Jonghakseo Jonghakseo closed this May 25, 2025
@PatrykKuniczak PatrykKuniczak mentioned this pull request May 28, 2025
Open
3 tasks
@PatrykKuniczak PatrykKuniczak deleted the branch Jonghakseo:dev July 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jonghakseo Jonghakseo Awaiting requested review from Jonghakseo Jonghakseo will be requested when the pull request is marked ready for review Jonghakseo is a code owner

Assignees

@niko-38500 niko-38500

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@niko-38500 @PatrykKuniczak @Jonghakseo @HiCreatrip @weilueluo