Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency hcloud-go to v2.2.0 #113

Merged
merged 1 commit into from Sep 24, 2023
Merged

update dependency hcloud-go to v2.2.0 #113

merged 1 commit into from Sep 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2023

@JonasProgrammer
Copy link
Owner

Hi,

thank you fro raising the issue and getting this PR filed! Given that I mostly run on Hetzner metal nowadays I'd probably have missed this.

Skimming over the diff in hcloud-go, I'm not entirely convinced this alone is sufficient to fix the issue. The legacy 'unscoped' actions client is still exposed, but will use the now-deprecated endpoint from what I get. Also I'm not 100% sure whether the plain /actions will be gone for good (i.e. including /actions/{id}) or whether it's just the global listing.
What baffles me is that https://docs.hetzner.cloud/changelog is still eerily quiet about this.

Anyways, I'm gonna merge the PR this weekend. I just want to have a look in a debugger what actually goes over the wire towards Hetzner. If aforementioned suspicion is correct, I've got to bite the bullet and migrate to a wait implementation per resource type.

@ghost
Copy link
Author

ghost commented Sep 21, 2023

Thank you! I was also suprised that it's only a "information" popup in the account and not in the changelog. Maybe it was overlooked because obviously someone informed some system with this update.

@JonasProgrammer JonasProgrammer merged commit 11a99a2 into JonasProgrammer:master Sep 24, 2023
@ghost ghost deleted the update_dependencies branch September 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant