Test if current url is a chrome scheme

Avoid showing the eruda menu for empty tabs
JingMatrix · Nov 13, 2023 · a958799 · a958799
1 parent 7866119
commit a958799
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/app/src/main/java/org/matrix/chromext/hook/PageInfo.kt b/app/src/main/java/org/matrix/chromext/hook/PageInfo.kt
@@ -50,15 +50,14 @@ object PageInfoHook : BaseHook() {
           controller!!.invokeMethod() { name == "destroy" }
         }
       }
-      Log.d("${infoRow}")
       return infoRow
     }
 
     proxy.pageInfoControllerRef.declaredConstructors[0].hookAfter { controller = it.thisObject }
 
     proxy.pageInfoController.declaredConstructors[0].hookAfter {
       val url = Chrome.getUrl()!!
-      if (controller == null) return@hookAfter
+      if (isChromeScheme(url) || controller == null) return@hookAfter
       (proxy.mRowWrapper.get(proxy.mView.get(it.thisObject)) as LinearLayout).addView(
           addErudaRow(url))
     }

diff --git a/app/src/main/java/org/matrix/chromext/hook/PageMenu.kt b/app/src/main/java/org/matrix/chromext/hook/PageMenu.kt
@@ -159,7 +159,7 @@ object PageMenuHook : BaseHook() {
                       mId.setAccessible(false)
                     }
 
-                    val skip = menu.size() <= 20
+                    val skip = menu.size() <= 20 || isChromeScheme(url)
                     // Inflate only for the main_menu, which has more than 20 items at least
 
                     if (skip && !isUserScript(url)) return@inflate

diff --git a/app/src/main/java/org/matrix/chromext/utils/Url.kt b/app/src/main/java/org/matrix/chromext/utils/Url.kt
@@ -123,3 +123,9 @@ fun parseOrigin(url: String): String? {
     return null
   }
 }
+
+fun isChromeScheme(url: String): Boolean {
+  val protocol = url.split("://")
+  return (protocol.size > 1 &&
+      arrayOf("chrome", "chrome-native", "edge").contains(protocol.first()))
+}