Skip to content

fix: increase RateLimiter maxSize to prevent IP eviction (#5893)#5929

Merged
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
vipul674:fix/ratelimiter-maxsize
Jun 18, 2026
Merged

fix: increase RateLimiter maxSize to prevent IP eviction (#5893)#5929
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
vipul674:fix/ratelimiter-maxsize

Conversation

@vipul674

Copy link
Copy Markdown
Contributor

Fixes #5893

Problem

RateLimiter was instantiated with maxSize=1, allowing only one IP to be tracked at a time. When a new IP made a request, the previous IP's entry was evicted, effectively disabling rate limiting for all users except the most recent one.

Fix

Increased maxSize from 1 to 10_000 in both ci-analytics and pr-insights route rate limiters, matching the default used elsewhere in the codebase.

maxSize=1 allowed only one IP to be tracked, evicting entries for
other IPs. This effectively disabled rate limiting for all users.

Fixes JhaSourav07#5893
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@vipul674 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vipul674

Copy link
Copy Markdown
Contributor Author

@JhaSourav07 Ready for review.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3628.47 KB 3628.47 KB 0 B
Total CSS 284.92 KB 284.92 KB 0 B

@vipul674

Copy link
Copy Markdown
Contributor Author

@JhaSourav07 Review Reminder

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected mentor:Aamod007 labels Jun 18, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficulty: beginner – Increases RateLimiter maxSize from 1 to 10,000 in ci-analytics and pr-insights routes to prevent IP eviction.

Quality: clean – Simple config fix.

Type: bug – Fixes issue #5893, prevents premature IP eviction.

Good fix!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 18, 2026
@JhaSourav07 JhaSourav07 merged commit 4cfd411 into JhaSourav07:main Jun 18, 2026
9 of 10 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @vipul674! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: RateLimiter maxSize=1 disables per-IP rate limiting in memory-fallback mode

3 participants