Add the ability to open the newly created migration in editor#278
Open
garidozv wants to merge 13 commits intoJetBrains:mainfrom
Open
Add the ability to open the newly created migration in editor#278garidozv wants to merge 13 commits intoJetBrains:mainfrom
garidozv wants to merge 13 commits intoJetBrains:mainfrom
Conversation
…it on the backend
- This function is called by the `RiderProjectModelWaiter.waitForProjectModelReadySuspending()`
seclerp
requested changes
Jun 11, 2025
...kotlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationDataContext.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/features/shared/ProjectEditorEx.kt
Outdated
Show resolved
Hide resolved
...otlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/OpenMigrationFileService.kt
Outdated
Show resolved
Hide resolved
… open a migration file in the editor
- Instead of calling potentially slow project synchronization functions on the main thread, react to the backend file creation event
- Use a single solution-wide component to listen to file creation events instead of creating a listener every time a file has to be opened
seclerp
requested changes
Jun 12, 2025
...tlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationDialogWrapper.kt
Outdated
Show resolved
Hide resolved
...com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationVfsListenerService.kt
Show resolved
Hide resolved
...otlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/OpenMigrationFileService.kt
Outdated
Show resolved
Hide resolved
...com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationVfsListenerService.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationDataContext.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationDataContext.kt
Outdated
Show resolved
Hide resolved
...otlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/OpenMigrationFileService.kt
Outdated
Show resolved
Hide resolved
seclerp
reviewed
Jun 12, 2025
seclerp
approved these changes
Jun 13, 2025
...tlin/com/jetbrains/rider/plugins/efcore/features/migrations/add/AddMigrationDialogWrapper.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #209