Adding 'Don't show again' button to ef core tools warning, resolves #213#216
Open
Nepp3r wants to merge 9 commits intoJetBrains:mainfrom
Open
Adding 'Don't show again' button to ef core tools warning, resolves #213#216Nepp3r wants to merge 9 commits intoJetBrains:mainfrom
Nepp3r wants to merge 9 commits intoJetBrains:mainfrom
Conversation
seclerp
requested changes
Mar 27, 2024
Member
seclerp
left a comment
seclerp
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution! Overall it's good for me, but please take a look at minor things in comments.
...otlin/com/jetbrains/rider/plugins/efcore/features/eftools/SuppressEfCoreToolsInstallation.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/startup/EfCoreStartupListener.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state/CommonOptionsStateService.kt
Outdated
Show resolved
Hide resolved
seclerp
requested changes
Mar 28, 2024
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state/CommonOptionsStateService.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state/CommonOptionsStateService.kt
Outdated
Show resolved
Hide resolved
...otlin/com/jetbrains/rider/plugins/efcore/features/eftools/SuppressEfCoreToolsInstallation.kt
Outdated
Show resolved
Hide resolved
seclerp
requested changes
May 19, 2024
Member
seclerp
left a comment
seclerp
left a comment
There was a problem hiding this comment.
Overall it looks good, thanks! Only the one little issue left
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/startup/EfCoreStartupListener.kt
Outdated
Show resolved
Hide resolved
Author
|
Thanks for the review! I've commited requested changes |
seclerp
approved these changes
May 21, 2024
…res/eftools/SuppressEfCoreToolsInstallation.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
…up/EfCoreStartupListener.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
…/CommonOptionsStateService.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
…/CommonOptionsStateService.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
…res/eftools/SuppressEfCoreToolsInstallation.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
…up/EfCoreStartupListener.kt Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
Nepp3r
force-pushed
the
DisEfCoreToolsNot
branch
from
2dc2998 to
bb1482a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.