Skip to content

SLC: fix missed annotation on no-args constructor #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jsjeon
Copy link
Collaborator

@jsjeon jsjeon commented May 15, 2025

^KT-77569 fixed

@jsjeon jsjeon requested a review from dimonchik0036 May 15, 2025 17:24
@jsjeon jsjeon requested a review from a team as a code owner May 15, 2025 17:24
Copy link
Member

@dimonchik0036 dimonchik0036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in general LGTM

@jsjeon jsjeon force-pushed the prr/jsjeon/slc-anno-on-no-arg-ctor branch from bc730b3 to be661c1 Compare May 16, 2025 18:53
@dimonchik0036 dimonchik0036 self-requested a review May 16, 2025 18:56
Copy link
Member

@dimonchik0036 dimonchik0036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check tests

@dimonchik0036
Copy link
Member

Merged (4a6e0da), thanks!

@jsjeon jsjeon deleted the prr/jsjeon/slc-anno-on-no-arg-ctor branch May 19, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants