Skip to content

Resolve library paths using realPath #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve library paths using realPath #5440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions kotlin-native/Interop/Runtime/src/jvm/kotlin/kotlinx/cinterop/JvmUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ private val systemTmpDir = System.getProperty("java.io.tmpdir")

// TODO: File(..).deleteOnExit() does not work on Windows. May be use FILE_FLAG_DELETE_ON_CLOSE?
private fun tryLoadKonanLibrary(dir: String, fullLibraryName: String, runFromDaemon: Boolean): Boolean {
val fullLibraryPath = try {
var fullLibraryPath = try {
Paths.get(dir, fullLibraryName)
} catch (ignored: InvalidPathException) {
return false
Expand All @@ -132,9 +132,7 @@ private fun tryLoadKonanLibrary(dir: String, fullLibraryName: String, runFromDae
}
}

val defaultTempDir = if (!runFromDaemon)
dir
else {
if (runFromDaemon) {
// Sometimes loading library from its original place doesn't work (it gets 'half-loaded'
// with relocation table haven't been substituted by the system loader without reporting any error).
// We workaround this by copying the library to some temporary place.
Expand All @@ -158,23 +156,30 @@ private fun tryLoadKonanLibrary(dir: String, fullLibraryName: String, runFromDae
} else {
tempDir.deleteRecursively()
}
defaultTempDir
fullLibraryPath = Paths.get(defaultTempDir, fullLibraryName)
}

// System load will throw `UnsatisfiedLinkError` if fullLibraryPath isn't resolved.
val realPath = fullLibraryPath.toRealPath().toString()
try {
System.load("$defaultTempDir/$fullLibraryName")
System.load(realPath)
} catch (e: UnsatisfiedLinkError) {
if (fullLibraryName.endsWith(".dylib") && e.message?.contains("library load disallowed by system policy") == true) {
if (realPath.endsWith(".dylib") && e.message?.contains("library load disallowed by system policy") == true) {
throw UnsatisfiedLinkError("""
|Library $dir/$fullLibraryName can't be loaded.
|${'\t'}This can happen because library file is marked as untrusted (e.g because it was downloaded from browser).
|${'\t'}You can trust libraries in distribution by running
|${'\t'}${'\t'}xattr -d com.apple.quarantine '$dir'/*
|${'\t'}command in terminal
|Library $realPath can't be loaded.
|${'\t'}This can happen because the library file is marked as untrusted (e.g because it was downloaded from browser).
|${'\t'}You can trust this library by running:
|${'\t'}${'\t'}xattr -d com.apple.quarantine '$realPath'
|${'\t'}in the terminal.
|${'\t'}Original exception message:
|${'\t'}${e.message}
""".trimMargin())
}

// Not sure what this work around is attempting to deal with.
// Note that copying a dylib to a temp directory and then loading it will
// cause the macOS virus scanner (XProtect) to scan it, so try and avoid doing
// this.
val tempDir = createTempDirWithLibrary()

File(tempDir).deleteOnExit()
Expand Down