Repository navigation
Bridge: Use real override as super bridge target - #5417
Closed
Xin Wang (scaventz) wants to merge 2 commits into
Closed
Xin Wang (scaventz) wants to merge 2 commits into
Xin Wang (scaventz) wants to merge 2 commits into
Conversation
Xin Wang (scaventz)
force-pushed
the
KT-72039
branch
from
March 28, 2025 13:07
479442f to
2ecf409
Compare
We don't generate bridges for Java classes, for a case like KT-72039, even though there is a real override `keySet()LKeySetView;` in `ConcurrentHashMap`, our Kotlin class `Test1` always sees it as a fake override by using `overriddenFromClass`, just because `ConcurrentHashMap` is not the direct super type of `Test1`. #KT-72039 Fixed
Alexander Udalov (udalov)
force-pushed
the
KT-72039
branch
from
July 31, 2025 11:01
2ecf409 to
5b99eea
Compare
Alexander Udalov (udalov)
approved these changes
Jul 31, 2025
Dmitriy Novozhilov (demiurg906)
approved these changes
Jul 31, 2025
Oleg Makeev (BlaBlaHuman)
approved these changes
Jul 31, 2025
Member
|
Merged in 46b69aa. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't generate bridges for Java classes, for a case like KT-72039, even though there is a real override
keySet()LKeySetView;inConcurrentHashMap, our Kotlin classTest1always see it as a fake override by usingoverriddenFromClass, just becauseConcurrentHashMapis not the direct super type of Test1.Fixes KT-72039