Preserve LLMParams fields after Prompt.withUpdatedParams
#1194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Preserves all
LLMParamsfields that were not updated duringPrompt.withUpdatedParams, including subtype of LLMParams instance. The biggest impact of this change is onPromptExecutor.executeStructured, where it erases all the properties that were not updated by the method for Native structured completion requests.Breaking Changes
No breaking changes.
Solution
I used
.copymethod fromLLMParamsthat is properly overwritten by its children instead ofLLMParamsUpdateContext.toParamsType of the changes
Checklist
developas the base branchprompt.*package, agent tests are red on my machine even before the PR)