[Work In Progress] Java API #1185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ololoshechkin
changed the title
Ololoshechkin
changed the title
kpavlov
reviewed
Nov 26, 2025
| */ | ||
| public fun <Input, Output> functionalStrategy( | ||
| public fun <Input, Output> graphStrategy( | ||
| name: String = "funStrategy", |
Contributor
There was a problem hiding this comment.
Should the name be changed as well? Should it be unique, use UUID then?
Contributor
There was a problem hiding this comment.
Is there a reason why it’s Java and not Kotlin?
| */ | ||
| public suspend fun execute( | ||
| prompt: Prompt, | ||
| model: LLModel, | ||
| tools: List<ToolDescriptor> = emptyList() | ||
| tools: List<ToolDescriptor> |
| version = run { | ||
| // our version follows the semver specification | ||
|
|
||
| val baseVersion = project.property("version") as String | ||
| val main = "0.6.0-java-1" |
Contributor
There was a problem hiding this comment.
you have outdated file. Please, change this in gradle.properties, if required
kpavlov
reviewed
Nov 28, 2025
Contributor
kpavlov
left a comment
kpavlov
left a comment
There was a problem hiding this comment.
How about we divide up the PR? The first thing that jumps out is adding @JvmOverloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Breaking Changes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature