Clamp endLine to file length and add warnings for overflow(KG-534 )
#1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faanbaria
requested review from
BLannoo,
EugeneTheDev,
denis-domanskii and
sproshev
Qodana for JVM1131 new problems were found
@@ Code coverage @@
+ 72% total lines covered
16630 lines analyzed, 12065 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
EugeneTheDev
approved these changes
Nov 30, 2025
| public data class Result(val file: FileSystemEntry.File) : ToolResult.TextSerializable() { | ||
| public data class Result( | ||
| val file: FileSystemEntry.File, | ||
| internal val warningMessage: String? = null |
Collaborator
There was a problem hiding this comment.
Generally it looks a bit weird when public data class has non-public fields. I see no reason to make it internal here, let's remove internal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When endLine exceeds the actual file length,
ReadFileToolthrows an error like "endLine=200 must be <= lineCount=50 or -1". Instead of failing, it should return all available lines with a warning.https://youtrack.jetbrains.com/issue/KG-534
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature