-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[JEWEL-1026] Add support for fractional palette indices #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daaria-s
wants to merge
1
commit into
JetBrains:master
Choose a base branch
from
daaria-s:daria.suvorova/JEWEL-1026
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+207
−44
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid breaking binary changes, we need to keep the old APIs, but deprecate them with
DeprecationLevel.HIDDENThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that means that I should just add new methods (grayOrNull(Int, Int) etc) and also keep the old ones (grayOrNull(Int) etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for example:
The hidden symbols will still disappear from the dumps, but they will be included in the binary and invisible from code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes — @faogustavo has helpfully listed a legend on how to read the dumps here:
So, you're deprecating with HIDDEN level the existing
blueOrNull(Int)— that's why it gets thebadded to its existingf(DeprecationLevel.HIDDENis a clever trick that (ab)uses the concept of a synthetic method in JVM bytecode). This is expected.Next, you added
blueOrNull(Int, Int = 0)where the second parameter has a default value; this is reflected in JVM bytecode as:f:blueOrNull-6MYuD4A(I,I)with two Int parameters, both non-optionalf:blueOrNull-6MYuD4A$default(...)that is generated by the compiler to implement the default parameter behaviourThe weird
-6MYuD4Asuffixes are also added by the Kotlin Compiler; it's called mangling and you can read more about it here: https://ncorti.com/blog/name-mangling-in-kotlin