Avoid cast exception and recursion in resolving SAM type used in constructor #3371
+90
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor PsiNewExpression#multiResolve uses super type's implementation of multiResolve---PsiPolyVariantCachingReference---by treating itself as a fake reference to a constructor. That super implementation may return ResolveResult[], including ResolveResult.EMPTY_ARRAY (if not resolved for some reason, like Lint CLI w/ different JDK, etc.), and the current direct cast to JavaResolveResult[] raised the class cast exception. A reproduction, however, failed in ToT Java UAST with a different error: recursive resolution attempts while resolving the lambda expression used in the constructor. The type of the lambda's parameter depends on the chosen method overload, but choosing the correct overload depends on the lambda's type, hence recursion. We can break the cycle by adding a guard to the process of resolving lambda parameter type. ^IDEA-383770 fixed
Contributor
Author
amaembo
approved these changes
Jan 9, 2026
| public JavaResolveResult @NotNull [] multiResolve(boolean incompleteCode) { | ||
| return (JavaResolveResult[])getConstructorFakeReference().multiResolve(incompleteCode); | ||
| ResolveResult[] results = getConstructorFakeReference().multiResolve(incompleteCode); | ||
| return results instanceof JavaResolveResult[] ? (JavaResolveResult[])results : JavaResolveResult.EMPTY_ARRAY; |
Contributor
There was a problem hiding this comment.
I don't like that we will silently replace non-empty ResolveResult[] array with an empty array. If there's a bug and non-JavaResolveResult appears, we should report it. I'll modify this code to:
ResolveResult[] results = getConstructorFakeReference().multiResolve(incompleteCode);
if (results instanceof JavaResolveResult[]) return (JavaResolveResult[])results;
return ContainerUtil.map2Array(results, JavaResolveResult.EMPTY_ARRAY, result -> (JavaResolveResult)result);
Contributor
|
Merged: 3e87a8c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PsiNewExpression#multiResolveuses super type's implementation ofmultiResolve---PsiPolyVariantCachingReference---by treating itself asa fake reference to a constructor. That super implementation may return
ResolveResult[], includingResolveResult.EMPTY_ARRAY(if not resolvedfor some reason, like Lint CLI w/ different JDK, etc.), and the current
direct cast to
JavaResolveResult[]raised the class cast exception.A reproduction, however, failed in ToT Java UAST with a different error:
recursive resolution attempts while resolving the lambda expression used
in the constructor. The type of the lambda's parameter depends on the
chosen method overload, but choosing the correct overload depends on the
lambda's type, hence recursion. We can break the cycle by adding a guard
to the process of resolving lambda parameter type.
^IDEA-383770 fixed