[JEWEL-1024] Improvements to SpeedSearchArea to support using for filter #3361
+1,336
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
requested review from
daaria-s,
nebojsa-vuksic,
rock3r and
wellingtoncosta
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
9ed15c7 to
8857fc4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt
Outdated
Show resolved
Hide resolved
...ewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/search/SpeedSearchableLazyColumn.kt
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
8857fc4 to
dc7354c
Compare
- Fixed index emission on SelectableLazyColumn when the selection changes by the speed search - Created 'EmptySpeedSearchMatcher' to easily identify when the filter text is empty - This matches is automatically returned in the SpeedSearchState.matcher when the text is empty - Added 'dismissOnLoseFocus' to SpeedSearchArea to keep the filter when the focus is left from the component - Added 'currentMatcher' to the 'SpeedSearchState', allowing the user use it for filtering purposes - Created convenience function on top of 'SpeedSearchMatcher' to check if the given text matches or not - Created convenience functions to support filtering collections based on the speed search matcher
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
dc7354c to
f2d590a
Compare
wellingtoncosta
approved these changes
Jan 8, 2026
Collaborator
wellingtoncosta
left a comment
wellingtoncosta
left a comment
There was a problem hiding this comment.
Just small suggestions, LGTM overall.
| public fun `filter strings should return only exact matching items`() { | ||
| val items = listOf("apple", "pineapple", "application", "banana") | ||
| val matcher = SpeedSearchMatcher.exactSubstringMatcher("apple") | ||
| val result = items.filter(matcher) { it } |
Collaborator
There was a problem hiding this comment.
I think you can use the Iterable<String>.filter() overload here to avoid this { it } block.
| public fun `filter strings should return empty list when no items match`() { | ||
| val items = listOf("apple", "banana", "cherry") | ||
| val matcher = SpeedSearchMatcher.exactSubstringMatcher("xyz") | ||
| val result = items.filter(matcher) { it } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidences
Release notes
New features
Bug fixes
Note
Introduces filtering-focused improvements and small fixes around speed search and selection.
SpeedSearchState,rememberSpeedSearchState,dismissOnLoseFocusflag, andSpeedSearchState.currentMatcher+ visibility controls; internal batching/caching for better performance.EmptySpeedSearchMatcher,SpeedSearchMatcher.doesMatch, andIterable.filter(...)extensions (strings and generics).SpeedSearchableLazyColumnScrollEffectnow reports selection viaonSelectedIndexChange;SelectableLazyColumnemits indices when selection changes via SpeedSearch and syncslastActiveItemIndex.dismissOnLoseFocus=false.Written by Cursor Bugbot for commit 8857fc4. This will update automatically on new commits. Configure here.