Change MAX_FILENAME_LENGTH to 180#845
Change MAX_FILENAME_LENGTH to 180#845crackleeeessyp wants to merge 1 commit intoJesusFreke:masterfrom
Conversation
On windows, if we put the apk/dex file on desktop or other path such as `C:\Users\xxxxxx\Desktop\folder\test.apk`. Some dex may produce long file path smali file which cannot handled by Windows application, so shorten the MAX_FILENAME_LENGTH to 180 to make sure that it works in most cases
|
Why? |
|
I had a similar issue with it on Linux and an encrypted partition . the maximum allowed filename length there is ~140 cause here and my issue was with an androidx class . so I think it might be here to stay |
|
That's right for windows can support path with length of 32767 characters, however, some program languages/ and old windows may not support 32767 but only 256, and would introduce problem when handle these long path files. Current implementation uses 256 as max file length, however, it doesn't consider that current folder path may contain several characters. I think @samuii1 is right, maybe we need find a way to make sure that long name not exceeded to 256 characters include current folder path character. |
On windows, if we put the apk/dex file on desktop or other path such as
C:\Users\xxxxxx\Desktop\folder\test.apk.Some dex may produce long file path smali file which cannot handled by Windows application, so shorten the MAX_FILENAME_LENGTH to 180 to make sure that it works in most cases.
Related issue:
iBotPeaches/Apktool#1582
#541