feat(from_str): support rename attribute#536
Open
tisonkun wants to merge 4 commits intoJelteF:masterfrom
Open
Conversation
Author
|
Let me try to fix CI failures. |
0b57522 to
fa1b3ac
Compare
tisonkun
commented
Jan 15, 2026
Author
There was a problem hiding this comment.
compiler error output diverges between stable and nightly. Not sure what we can do.
Author
There was a problem hiding this comment.
Weird. I run cargo +stable test --workspace --features full,testing-helpers locally and it doesn't fail:
rustc --version --verbose
rustc 1.92.0 (ded5c06cf 2025-12-08)
binary: rustc
commit-hash: ded5c06cf21d2b93bffd5d884aa6e96934ee4234
commit-date: 2025-12-08
host: aarch64-apple-darwin
release: 1.92.0
LLVM version: 21.1.3
fa1b3ac to
6615354
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refers to #216 and #480
Synopsis
This supports:
Solution
Checklist