noReady functionality for publish#37
Open
aaronthorp wants to merge 2 commits intoJcBernack:masterfrom
Open
Conversation
…asday:publish-counts package
JcBernack
reviewed
Feb 28, 2018
| }); | ||
|
|
||
| export const ReactiveAggregate = function (subscription, collection, pipeline = [], options = {}) { | ||
| export default ReactiveAggregate = function (subscription, collection, pipeline = [], options = {}) { |
Owner
There was a problem hiding this comment.
This is weird, please use export default function ReactiveAggregate(...).
Owner
|
Thanks. Please fix the one export issue and I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
noReady: trueoption to options variable allowing optional ready state to allow for in-publish aggregation similar totmeasday:publish-counts.Example use: eCommerce store listing products, aggregation to get distinct
brandfield for filtering using the existing search keywords or product category/other filters selected.Also modified export to default export to allow for use of
import ReactiveAggregate from 'meteor/jcbernack:reactive-aggregate'instead of
import { ReactiveAggregate } from 'meteor/jcbernack:reactive-aggregate'as there are no other variables for importing from this package.