Repository navigation
fix(core): mock "Audit agrees with evidence" no longer contradicts an inspector's not-done line - #201
Merged
Conversation
…s a line not done It always said "[mock] Inspector checklist agrees with builder evidence" whenever an audit existed, so the row contradicted a red "Inspector checklist complete" right above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
In the mock verifier core uses for the devnet demo (
packages/core/src/fakes/fake-verifier.ts), the "Audit agrees with evidence" row always said[mock] Inspector checklist agrees with builder evidencewhenever an audit existed. If the inspector marked a Schedule of Values linenot_doneorpartial:That contradiction is visible on the project page, and it's the case the demo video now shows: the builder bills the full Framing draw, and the inspector finds the roof trusses aren't up.
Change
audit_matches_evidencenow warns when any checklist line isn'tdone. The reason reads:[mock] Inspector marked N of M items not done; the builder's evidence claims the stage complete.fail. Every line done → stillpass, with the same text.Release decisions
not_doneline already failsaudit_checklist_complete, so the milestone was already held.partialline already warned (→needs_human), so that decision doesn't change either.packages/verifier) is not touched.Tests
verdict-reasons.test.ts"inspector marks a line not done". It fails onmainand passes here.pnpm -r typecheck && pnpm -r testare green.