Skip to content

fix(core): mock "Audit agrees with evidence" no longer contradicts an inspector's not-done line - #201

Merged
seanpatrickmay merged 1 commit into
mainfrom
seanpatrickmay/fix-mock-audit-vs-evidence
Oct 25, 2026
Merged

seanpatrickmay merged 1 commit into
mainfrom
seanpatrickmay/fix-mock-audit-vs-evidence

Conversation

@seanpatrickmay

Copy link
Copy Markdown
Collaborator

What was wrong

In the mock verifier core uses for the devnet demo (packages/core/src/fakes/fake-verifier.ts), the "Audit agrees with evidence" row always said [mock] Inspector checklist agrees with builder evidence whenever an audit existed. If the inspector marked a Schedule of Values line not_done or partial:

  • "Inspector checklist complete" went red, correctly;
  • the row directly under it still claimed the inspector agreed with the builder.

That contradiction is visible on the project page, and it's the case the demo video now shows: the builder bills the full Framing draw, and the inspector finds the roof trusses aren't up.

Change

  • audit_matches_evidence now warns when any checklist line isn't done. The reason reads: [mock] Inspector marked N of M items not done; the builder's evidence claims the stage complete.
  • No audit → still fail. Every line done → still pass, with the same text.

Release decisions

  • Unchanged in practice: a not_done line already fails audit_checklist_complete, so the milestone was already held.
  • A partial line already warned (→ needs_human), so that decision doesn't change either.
  • Only the reason text and the row's colour change.
  • The live verifier (packages/verifier) is not touched.

Tests

  • New: verdict-reasons.test.ts "inspector marks a line not done". It fails on main and passes here.
  • pnpm -r typecheck && pnpm -r test are green.

…s a line not done

It always said "[mock] Inspector checklist agrees with builder evidence" whenever an audit existed, so the row
contradicted a red "Inspector checklist complete" right above it.
@seanpatrickmay
seanpatrickmay merged commit fc7624f into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant