Skip to content

Update libm and change rust-version to match. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update libm and change rust-version to match. #29

merged 1 commit into from
Oct 28, 2024

Conversation

JSorngard
Copy link
Owner

@JSorngard JSorngard commented Oct 28, 2024

libm set their msrv to 1.63 in a semver-compatible update, and since this crate depends on libm we can not have a lower msrv. This PR updates the msrv of the crate.

Related: rust-lang/libm#330

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f60d69b) to head (054838f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1865      1865           
=========================================
  Hits          1865      1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard JSorngard merged commit 940fa5f into main Oct 28, 2024
7 checks passed
@JSorngard JSorngard deleted the libm_msrv branch October 28, 2024 10:44
@JSorngard
Copy link
Owner Author

The update of this crate also has to be a patch version, since the update of libm also affects previous versions of this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants