Support PostgreSQL conflict index elements, OVERRIDING USER and MERGE RETURNING - #2569
Open
minleejae wants to merge 2 commits into
Open
Support PostgreSQL conflict index elements, OVERRIDING USER and MERGE RETURNING#2569minleejae wants to merge 2 commits into
minleejae wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL INSERT currently rejects conflict targets mixing columns and expressions, accepts only OVERRIDING SYSTEM VALUE, and MERGE has no RETURNING clause. This adds ordered conflict keys with COLLATE and schema-qualified operator classes, distinguishes USER/SYSTEM overriding, and connects MERGE to the existing ReturningClause (including OLD/NEW output aliases). Bare function keys and OVERRIDING without a column list are supported.
The target reuses Index.ColumnParams and centralizes expression traversal and rendering. Existing conflict-column getters remain mutable views, existing replacement methods remain available, and the boolean overriding API still maps true to SYSTEM. MERGE RETURNING uses visitor-based output; ExpressionDeParser now preserves normalized OLD/NEW qualifiers. Statement visitors, table discovery and validators visit the newly supported expressions.
Validation:
References: PostgreSQL INSERT, PostgreSQL MERGE.