Complete MySQL index options and share CREATE INDEX rendering - #2567
Open
minleejae wants to merge 4 commits into
Open
Complete MySQL index options and share CREATE INDEX rendering#2567minleejae wants to merge 4 commits into
minleejae wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL DROP INDEX rejects DEFAULT option values, and CREATE/DROP INDEX reject LOCK EXCLUSIVE. Parse their algorithm/lock options through a shared production while retaining the existing token-list APIs, option order and optional equals signs. A CREATE INDEX tail production keeps these options separate from the generic DDL parameter parser and preserves a following LOCK TABLE statement boundary.
CreateIndex.appendTo now supplies the model and CreateIndexDeParser output, removing their duplicate CREATE INDEX renderers. Header, target and key-list rendering are split into focused helpers. PostgreSQL structured tails and legacy raw tails remain supported.
The existing nested-bracket timing check failed intermittently during validation on Linux and macOS. It now compares five-sample median durations from a monotonic clock, preserving its growth threshold and parse/deparse assertions.
Validation:
References: MySQL CREATE INDEX, MySQL DROP INDEX.