Skip to content

build: pin file.encoding so the Maven build works on Windows #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 2 commits into from
Sep 10, 2026
+9 −2
Merged

build: pin file.encoding so the Maven build works on Windows #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5256d4
build: pin file.encoding so the Maven build generates the parser on W…
knutwannheden Sep 10, 2026
8c65dab
build: pin file.encoding for the forked test JVMs as well
knutwannheden Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# windows-latest disabled: see #<issue> — record the reason, not just the comment
os: [ ubuntu-latest, macos-latest ]
os: [ ubuntu-latest, windows-latest, macos-latest ]
steps:
- uses: actions/checkout@v5
with:
Expand Down
1 change: 1 addition & 0 deletions .mvn/jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-Dfile.encoding=UTF-8
7 changes: 7 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,11 @@
<goals>
<goal>jjtree-javacc</goal>
</goals>
<!--
GRAMMAR_ENCODING governs reading only: JJTree writes the intermediate
.jj with the JVM default charset, which mangles the grammar's non-ASCII
character classes unless file.encoding is UTF-8 (see .mvn/jvm.config).
-->
<configuration>
<javaccCmdLineArgs>
<arg>-CODE_GENERATOR:"Java"</arg>
Expand Down Expand Up @@ -564,11 +569,13 @@
@{jacocoArgLine} is resolved late, after jacoco:prepare-agent has run.
Without it the JaCoCo agent would be dropped and coverage reports empty.
-->
<!-- Forked test JVMs do not inherit .mvn/jvm.config, so pin the encoding here too. -->
<argLine>
@{jacocoArgLine}
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
-Xmx2G -Xms800m -Xss4m
-Dfile.encoding=UTF-8
</argLine>
</configuration>
</plugin>
Expand Down
Loading